Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging markers not working in Safari #83

Closed
emxsys opened this issue Jan 31, 2018 · 1 comment
Closed

Dragging markers not working in Safari #83

emxsys opened this issue Jan 31, 2018 · 1 comment
Labels
bug
Milestone
Explorer 0.2.0

Comments

@emxsys
Copy link
Member

emxsys commented Jan 31, 2018

The globe is panning with the cursor when attempt to drag/move a marker.
@emxsys emxsys added the bug label Jan 31, 2018
@emxsys emxsys added this to the Explorer v0.2.0 milestone Jan 31, 2018
@emxsys emxsys closed this as completed in 34d05ed Feb 4, 2018
emxsys added a commit that referenced this issue Feb 4, 2018
@emxsys
Updated PickController with call to stopImmediatePropagation.
d45fa83 
- Prevents panning globe when dragging a marker.
- Required for Safari.
- Fixes #83
@emxsys
Copy link
Member Author

emxsys commented Feb 4, 2018

Safari required a called to event.stopImmediatePropagation to prevent the panning event handler from being called. The call to event.preventDefault was not sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Explorer 0.2.0
Development

No branches or pull requests
1 participant
@emxsys