Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Battle.net OAuth #131

Closed
Wotuu opened this issue Feb 13, 2019 · 3 comments
Closed

Implement Battle.net OAuth #131

Wotuu opened this issue Feb 13, 2019 · 3 comments
Assignees
@Wotuu
Labels
enhancement New feature or request
Milestone
Improve user inte...

Comments

@Wotuu
Copy link
Contributor

Wotuu commented Feb 13, 2019

https://develop.battle.net/documentation/guides/using-oauth

This should quell some of the voices which are reluctant to sign up for the website. People should be able to couple their existing account to a Battle.net account and 'delete' their Keystone.guru account, which I think will amount to their e-mail address being removed from the database.
@Wotuu Wotuu added the enhancement New feature or request label Feb 13, 2019
@Wotuu
Copy link
Contributor Author

Wotuu commented Apr 18, 2019

Also https://auth0.com/docs/connections/social/google

@Wotuu
Copy link
Contributor Author

Wotuu commented Apr 18, 2019

https://medium.com/employbl/add-login-with-google-to-your-laravel-app-d2205f01b895
https://medium.com/laravel-news/adding-auth-providers-to-laravel-socialite-ca0335929e42
https://laravel.com/docs/5.8/socialite

Wotuu added a commit that referenced this issue Apr 19, 2019
@Wotuu
#131 Added Google Signin
a988799
Wotuu added a commit that referenced this issue Apr 21, 2019
@Wotuu
#131 Implemented OAuth2 for Battle.net, Discord and Google.
9030f33 
To make use of the GameServerRegions for Battle.net login, renamed NA to US for Americas region.
Added an oauthid to all users to identify returning users that previously registered through oauth.
@Wotuu
Copy link
Contributor Author

Wotuu commented Apr 26, 2019

In the end, I've added support for logging in/registering through Google, Battle.net and Discord. More upon request. This'll do for now!

@Wotuu Wotuu closed this as completed Apr 26, 2019
@Wotuu Wotuu self-assigned this Apr 26, 2019
Wotuu added a commit that referenced this issue May 9, 2019
@Wotuu
#131 Abstracted some more in OAuth flow. Fixed some more issues along…
c31ead1 
… the way.
Wotuu added a commit that referenced this issue May 14, 2019
@Wotuu
#131 Fixed possible duplicate usernames from being registered through…
f9de085 
… OAuth.
Wotuu added a commit that referenced this issue May 14, 2019
@Wotuu
#131 More code cleanup for OAuth.
aea0933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wotuu Wotuu

Labels
enhancement New feature or request
Projects
None yet
Milestone
Improve user interface/experience
Development

No branches or pull requests
1 participant
@Wotuu