Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapObjectGroup.objects keys should be IDs, not indices #849

Closed
Wotuu opened this issue Jul 17, 2021 · 0 comments
Closed

MapObjectGroup.objects keys should be IDs, not indices #849

Wotuu opened this issue Jul 17, 2021 · 0 comments
Assignees
@Wotuu
Labels
enhancement New feature or request map Issue that is related to the map

Comments

@Wotuu
Copy link
Contributor

Wotuu commented Jul 17, 2021

This can cut out a lot of loops and make the map more performant/responsive.
@Wotuu Wotuu added enhancement New feature or request map Issue that is related to the map labels Jul 17, 2021
Wotuu added a commit that referenced this issue Aug 20, 2022
@Wotuu
#849 Improved performance of the route viewing tool.
c103fe9 
The mapobjectgroup.findMapObjectById() method used to iterate over all objects it had to find a map object - this internal array has been replaced with an object instead, allowing instant lookups instead of costly loops. Locally the performance increase is noticeable, on prod it won't be as noticeable but on lower performing hardware it can be much quicker
@Wotuu Wotuu self-assigned this Aug 20, 2022
@Wotuu Wotuu closed this as completed Aug 20, 2022
This was referenced Aug 21, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wotuu Wotuu

Labels
enhancement New feature or request map Issue that is related to the map
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Wotuu