Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Legion routes page #883

Closed
Wotuu opened this issue Sep 21, 2021 · 0 comments
Closed

Create Legion routes page #883

Wotuu opened this issue Sep 21, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Wotuu
Copy link
Contributor

Wotuu commented Sep 21, 2021

Relevant conversation:

13:39] Wotuu: @here Hey guys/girls! Yesterday I've finished the Legion mapping (good enough anyways), and now I just got one thing left to do before I can push the update live. So I got a question for you, how should I go about including the Legion section on the site? For example, the current routes page https://keystone.guru/routes page will default to the current expansion - but obviously I can have the same section available for Legion dungeons, and in the future also for BFA M+ since that's only a matter of time.

Should I include new links in the top header for "Shadowlands routes", "Legion routes"? Or should I add something like a dropdown where you can select the expansion that the site is in, that will hit multiple other places of the site. Think of that /routes page, but also viewing your own routes for example would then only show Legion routes. Or perhaps some other way I haven't thought of? Let me know what you think :slight_smile:
[13:42] Melithian:
: Should I include new links in the top header for "Shadowlands routes", "Legion routes
I think that's enough, tbh
[13:43] Wotuu: I was thinking the same thing, introducing said dropdown in the top header may just confuse people as for why their /routes page is different than others, plus it wouldn't allow direct linking while say /routes/legion would
[13:44] Melithian: Yes, I think thats better and probably easier to implement. Probably more future-proof as well, when we eventually get BfA Timewalking
[13:51] Wotuu: Yeah for sure easier to implement and more transparent 👍 thanks, I'll get on that right away!

@Wotuu Wotuu added the enhancement New feature or request label Sep 21, 2021
@Wotuu Wotuu self-assigned this Sep 21, 2021
Wotuu added a commit that referenced this issue Sep 21, 2021
Still need to add proper functionality but will get there.
Wotuu added a commit that referenced this issue Sep 22, 2021
Wotuu added a commit that referenced this issue Sep 22, 2021
@Wotuu Wotuu closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant