Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Motor Brake Version Message #201

Closed
WouterJD opened this issue Jan 10, 2021 · 7 comments
Closed

Improve Motor Brake Version Message #201

WouterJD opened this issue Jan 10, 2021 · 7 comments
Labels
bug Something isn't working solved

Comments

@WouterJD
Copy link
Owner

@mattipee Interesting!

tt-YY-##### (tt=41 (T1941), YY=year, ##### brake individual serial)

So I have to convert Serial to string and then interpret left-to-right; since ##### may be #### ### ## # ??

For a serial-number 1903 I expected 410601903 :-)
https://github.com/WouterJD/FortiusANT/blob/5.1%2B4.2-Quality-upgrade/pythoncode/usbTrainer.py#L2948

Originally posted by @WouterJD in #197 (comment)
@WouterJD WouterJD added the bug Something isn't working label Jan 10, 2021
@mattipee
Copy link
Contributor

Easiest first step would be to include the raw value in the printout, alongside the "parsed" fields.

WouterJD added a commit that referenced this issue Jan 10, 2021
@WouterJD
#201
25388fc
WouterJD added a commit that referenced this issue Jan 10, 2021
@WouterJD
#201
47735e8
@WouterJD
Copy link
Owner Author

I suggest following change
https://github.com/WouterJD/FortiusANT/blob/5.1%2B4.2-Quality-upgrade/pythoncode/usbTrainer.py#L2950

raw data is in the log, this print should be informative for the user.

@mattipee
Copy link
Contributor

Much easier to read!

@WouterJD
Copy link
Owner Author

Version 5.1 Test III is available with major update on Motor/Magnetic brake determination.
(for details see wiki)

Please test

@TacxBiker
Copy link

seems to work just fine

@WouterJD
Copy link
Owner Author

WouterJD commented Jan 13, 2021 •
edited

see TotalReverse's info

Solid information for further improvement.

@WouterJD
Copy link
Owner Author

Implemented in 5.1 Test V

WouterJD added a commit that referenced this issue Jan 21, 2021
@WouterJD
5.1+4.2 quality upgrade (#198)
ec1988d 
* #184 Power in Rouvy issue

* #173 Version 4.0 Communicates Much Higher Power vs. 3.8

* #184 Power in Rouvy issue #2

* #184 Power in Rouvy issue #2

* #184 Power in Rouvy issue #3

* Fortius Antifier v4.2 test IV

* Fortius Antifier v5.1 test I

* Fortius Antifier v5.1 test II

* Fortius Antifier v5.1 test IIb

* #201

* #201

* Fortius Antifier v5.1 test III

* heart -> Heart2

* heart -> Heart2

* heart* -> heart.jpg

* Fortius Antifier v5.1 test IV

* Fortius Antifier v5.1 test V

* Fortius Antifier v5.1 test VI

* Fortius Antifier v5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattipee @WouterJD @TacxBiker