You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Might be a LibSink issue, but having blizzards floating combat text disabled currently breaks the addon for me.
Hovering over the minimap button causes Rarity to try to call a function from Blizzard's combat text, which is not available once it is disabled causing Rarity to not show the tooltip.
I use XCT+ and have set enableFloatingCombatText (CVar) to 0. The problem is, that even if I set the output channel to Default, XCT or anything else than Blizzards Combat Text, the issue remains.
I had the same issue with Kaliel's Tracker (quest tracker addon), but it can be fixed there by setting the output channel to XCT.
Will post the LUA error.
- if tostring(SHOW_COMBAT_TEXT) ~= "0" then+ if CVarCallbackRegistry:GetCVarValueBool("enableFloatingCombatText") then
if type(CombatText_AddMessage) == "nil" then
UIParentLoadAddOn("Blizzard_CombatText")
end
CombatText_AddMessage(text, CombatText_StandardScroll, 1, 1, 1, true, false)
else
UIErrorsFrame:AddMessage(text, 1, 1, 1, 1.0)
end
does indeed seem to work. No lua errors and I am also getting output in XCT now.
Might be a LibSink issue, but having blizzards floating combat text disabled currently breaks the addon for me.
Hovering over the minimap button causes Rarity to try to call a function from Blizzard's combat text, which is not available once it is disabled causing Rarity to not show the tooltip.
I use XCT+ and have set enableFloatingCombatText (CVar) to 0. The problem is, that even if I set the output channel to Default, XCT or anything else than Blizzards Combat Text, the issue remains.
I had the same issue with Kaliel's Tracker (quest tracker addon), but it can be fixed there by setting the output channel to XCT.
Will post the LUA error.
edit: I just diff'ed the LibSink files of Kalil's Tracker and Rarity, and they are identical. Commenting out these lines:
(MainWindow.lua:1159) fixes the exception. Though probably the output isn't working for me now.
The text was updated successfully, but these errors were encountered: