Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking for BFA salvage crates that may contain Island Expedition collectibles #601

Closed
Duckwhale opened this issue Aug 7, 2023 · 1 comment · Fixed by #603
Closed

Comments

@Duckwhale
Copy link
Member

Duckwhale commented Aug 7, 2023

Rarity doesn't track salvage crates. I think it would be possible to just change the detection method to USE for Island Expedition items? Those items currently use SPECIAL and some custom event handling to add attempts after every run. Not sure if there'd be side effects to changing this. Also, IIRC there are complex requirements for the drop itself that aren't really being captured.

@Duckwhale
Copy link
Member Author

Duckwhale commented Aug 8, 2023

One wrinkle: The drop rates are (obviously) very different, with no way to differentiate currently.

With drop rates on the order of 5-10% (according to wowhead data), but Rarity currently using 1 in 1000, and the real probability being unknown for expeditions themselves - but scaling by difficulty... I don't have any hope for getting it right. So the best worst solution might be to just leave it at that and accept that anyone who opens crates will see a wrong drop rate.

Edit: The alternative is to set it to 5-10%, but then people might assume that these collectibles drop frequently from expeditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant