-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support docker --context
#13
Comments
I decided not to implement all possible docker and docker compose flags if they can be provided via an environment variable to keep this tool simple, would this work for your use case? env DOCKER_CONTEXT=production docker rollout (See Docker profiles #5 (comment) and remote deployment #6 (comment)) |
Yes this works OK. I had thought you could just pass arbitrary additional flags to docker and compose as follows. i.e.
And |
Actually, it sounds like a good idea to pass unknown flags, but there's a catch: the script uses |
Not sure I understand the problem; you could pass them like I described in the last comment? Is there something wrong with my suggestion? Obviously the decision of how to spend your time is entirely yours. Thanks for the tool :) |
Oh sorry, I didn't get your idea at first. Would be great, but I'm not sure if I'm able to access flags passed to docker commands, because the docker plugin integration is pretty basic. Will check |
It works as I expected, thank you for the suggestion. Arguments before Released as https://github.com/Wowu/docker-rollout/releases/tag/v0.6 |
Could you support the docker --context flag?
It's used like this, to take the example from the Docker docs:
I suppose you'd need to change something around here:
and here:
Shell scripting is not at all my strength so I'm hesitant to dive in myself.
The text was updated successfully, but these errors were encountered: