Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding Integration - not really an issue #5

Open
wgumaa opened this issue Jan 29, 2024 · 33 comments
Open

Question regarding Integration - not really an issue #5

wgumaa opened this issue Jan 29, 2024 · 33 comments

Comments

@wgumaa
Copy link

wgumaa commented Jan 29, 2024

Hey @Woyken, does this still require @mauro-midolo HACS integration.

I ask because the repo for Home Assistant Electrolux Care Integration (Not Official) is gone from HACS.

image

@Woyken
Copy link
Owner

Woyken commented Jan 29, 2024

Interesting, looks like he deleted that repo completely.
Anyway, this is a API wrapper library. It doesn't matter which integration uses it.
Looks like some work has already been started on:
https://github.com/albaintor/homeassistant_electrolux_status
That's good news.

We'll have to wait and see how all of this is going to work out

@mauro-midolo
Copy link

Hi all,

I recently read this article https://www.ilsoftware.it/haier-contro-i-plugin-home-assistant-minaccia-azioni-legali/.
I don't want to do anything illegal or anything not approved by Elettrolux.
For these reasons I decided to delete and remove the integration.

If someone wants to create a new integration, perhaps even asking for authorization directly from electrolux, take the path.

Sorry for the inconvenience.

@Woyken
Copy link
Owner

Woyken commented Jan 29, 2024

@mauro-midolo
Thanks for letting us know.
It's understandable. Recently there have been a few companies that shut down open source projects like this, which is really sad.
Thank you for all the time you put into this project

@wgumaa
Copy link
Author

wgumaa commented Jan 29, 2024

@mauro-midolo, I understand your concern, but you haven't done anything illegal.

As I understand, the API is public. Meaning that if the Electrolux group did not want "apps" to use it they would not have made it public.

They even have a developers portal here for API use: https://portal-eu-nonprod.electrolux.com/

But I don't know how you would sign up. The most they can do is to send a letter asking you to take the repo down.

"The plugins themselves are open-source, but it is unclear if they incorporate Haier's intellectual property, such as software code or proprietary protocols, which would give the firm a legal basis for the request.

On the other hand, if the plugins do not infringe on Haier's intellectual property or fall under fair use provisions, the creator could opt to defend his work and keep the plugins available to the community."

https://www.bleepingcomputer.com/news/security/haier-hits-home-assistant-plugin-dev-with-takedown-notice/

However, in the end they didn't and the repo still is there! https://github.com/Andre0512/hon

You have the community behind you so I encourage you to keep going. Once we hit critical mass then that's a different story.

@brettjenkins
Copy link

Hi all,

I recently read this article https://www.ilsoftware.it/haier-contro-i-plugin-home-assistant-minaccia-azioni-legali/. I don't want to do anything illegal or anything not approved by Elettrolux. For these reasons I decided to delete and remove the integration.

If someone wants to create a new integration, perhaps even asking for authorization directly from electrolux, take the path.

Sorry for the inconvenience.

You didn't have to delete it.

Few things, they'd give you a warning first, but my understanding is Haier rolled back their demands anyway. Secondly, you could have let someone fork it, rather than deleting all the code...

@allistermaguire
Copy link

allistermaguire commented Jan 29, 2024

There are forks around. I also have a fork that I synced yesterday as I was going to submit a couple of PRs for enumeration and a couple of issues I ran into. I was waiting to see what path @mauro-midolo was going to go down.

I don't intend to run a project as I am not a developer, I also don't use HACS. But anyone is welcome to fork https://github.com/allistermaguire/homeassistant_electrolux_status or I can transfer it to someone.

Thank you @mauro-midolo for providing us with a way to use Electrolux appliances with Hass up until now, much appreciated.

@mauro-midolo
Copy link

@mauro-midolo, I understand your concern, but you haven't done anything illegal.

As I understand, the API is public. Meaning that if the Electrolux group did not want "apps" to use it they would not have made it public.

They even have a developers portal here for API use: https://portal-eu-nonprod.electrolux.com/

But I don't know how you would sign up. The most they can do is to send a letter asking you to take the repo down.

"The plugins themselves are open-source, but it is unclear if they incorporate Haier's intellectual property, such as software code or proprietary protocols, which would give the firm a legal basis for the request.

On the other hand, if the plugins do not infringe on Haier's intellectual property or fall under fair use provisions, the creator could opt to defend his work and keep the plugins available to the community."

https://www.bleepingcomputer.com/news/security/haier-hits-home-assistant-plugin-dev-with-takedown-notice/

However, in the end they didn't and the repo still is there! https://github.com/Andre0512/hon

You have the community behind you so I encourage you to keep going. Once we hit critical mass then that's a different story.

Ciao @wgumaa,
Is there any documentation provided by Electrolux that declares that those bees are public and usable by everyone?

@ErikvO
Copy link

ErikvO commented Jan 29, 2024

@mauro-midolo
Haier had a change of heart. See here, which I had already posted in your repository as well a couple of days ago.

@wgumaa
Copy link
Author

wgumaa commented Jan 29, 2024

@mauro-midolo I was able to find their developer portal but cannot access it. But i did find that they are a member of https://openconnectivity.org/ and they have many products that are listed under that open source framework:

https://openconnectivity.org/certified-products/

@slingshot74
Copy link

slingshot74 commented Jan 29, 2024

@mauro-midolo I don't think you have to worry. People, including me, buy Electrolux and AEG products because of the integration possibility with HA.
So they are happy with this kind of integrations.

@schumi2004
Copy link

schumi2004 commented Jan 30, 2024

Just added https://github.com/albaintor/homeassistant_electrolux_status as a custom repo in HACS, let's see what happens.

/edit
And it seems to work.
I do seem to miss a few sensors for my washing machine like detergent level etc
vivaldi_BwvacofklM

@slingshot74
Copy link

@schumi2004 How did you add it to HACS? I can't find the electolux status in HACS

@wgumaa
Copy link
Author

wgumaa commented Jan 30, 2024

@schumi2004 How did you add it to HACS? I can't find the electolux status in HACS

Its a custom install: HACS > press the 3 dots > Custom Repository > Post the link (https://github.com/albaintor/homeassistant_electrolux_status) > Select Integration

@wgumaa
Copy link
Author

wgumaa commented Jan 30, 2024

Just added https://github.com/albaintor/homeassistant_electrolux_status as a custom repo in HACS, let's see what happens.

/edit And it seems to work. I do seem to miss a few sensors for my washing machine like detergent level etc vivaldi_BwvacofklM

@schumi2004 I lost the integration!!!

@schumi2004
Copy link

schumi2004 commented Jan 30, 2024

Just added https://github.com/albaintor/homeassistant_electrolux_status as a custom repo in HACS, let's see what happens.
/edit And it seems to work. I do seem to miss a few sensors for my washing machine like detergent level etc vivaldi_BwvacofklM

@schumi2004 I lost the integration!!!

What do you mean with lost integration?
Re-add it in Home Assistant, it should be named: Electrolux Care Integration V2

To be on the safe side i removed the old HACS integration.

@Woyken
Copy link
Owner

Woyken commented Jan 30, 2024

Looks like there is another fork by witold-gren that is being worked on too
https://github.com/witold-gren/homeassistant_electrolux_status
This fork is active too:
https://github.com/albaintor/homeassistant_electrolux_status

@wgumaa
Copy link
Author

wgumaa commented Jan 31, 2024

Found a fork that works

@slingshot74
Copy link

@wgumaa which one is it?

@wgumaa
Copy link
Author

wgumaa commented Jan 31, 2024

@wgumaa which one is it?

If you go to HACS and search Electrolux it the last one.

However it's the last version beta so still not all entities are available or correct

@slingshot74
Copy link

slingshot74 commented Jan 31, 2024

Okay thanks that one doesn't work for me. I get an error. They know what it is. But after that the development has stopped :(

For me it's unclear if there is a fork where the development continuous.

@schumi2004
Copy link

Okay thanks that one doesn't work for me. I get an error. They know what it is. But after that the development has stopped :(

For me it's unclear if there is a fork where the development continuous.

What kind of error?

Else remove all excisiting Electrolux (HACS) integrations and add this custom HACS repo https://github.com/albaintor/homeassistant_electrolux_status like explained by #5 (comment)

Download in HACS and install new integration.

Should work perfect except a few entities are missing for now.

@slingshot74
Copy link

slingshot74 commented Jan 31, 2024

@schumi2004 It's a know issue and depends on your device you have. I have an AEG dryer.
I am pretty sure I use the repro you mentioned.
It was addressed by @albaintor but then the development stopped.
After log in there is an error and it keeps trying, (which will block the account for a while)

Logger: py.warnings
Source: runner.py:188
First occurred: 11:46:09 (1 occurrences)
Last logged: 11:46:09

/usr/local/lib/python3.11/asyncio/base_events.py:1926: RuntimeWarning: coroutine 'OneAppApi.get_appliances_list' was never awaited handle = None # Needed to break cycles when an exception occurs.

=== AFTER THAT ===
Logger: homeassistant
Source: runner.py:145
First occurred: 11:46:19 (3 occurrences)
Last logged: 11:46:19

Error doing job: Unclosed client session
Error doing job: Unclosed connector

=== AFTER THAT ===
This error originated from a custom integration.

Logger: custom_components.electrolux_status
Source: custom_components/electrolux_status/init.py:109
Integration: Electrolux Care Integration V2 (documentation, issues)
First occurred: 11:46:12 (2 occurrences)
Last logged: 11:46:19

'NoneType' object has no attribute 'get'
Traceback (most recent call last):
File "/config/custom_components/electrolux_status/init.py", line 109, in _async_update_data
app.setup(ElectroluxLibraryEntity(appliance_name, connection_state, appliance_status,
File "/config/custom_components/electrolux_status/api.py", line 338, in setup
self.entities = [
^
File "/config/custom_components/electrolux_status/api.py", line 339, in
entity.setup(data)
File "/config/custom_components/electrolux_status/api.py", line 194, in setup
self._state = data.get_value(self.attr, self.field, self.source)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/electrolux_status/api.py", line 34, in get_value
entry = container.get(attr_name)
^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'get'

@albaintor
Copy link

Hi I am still on it but I was busy. I had to rewrite many parts to make it work

@slingshot74
Copy link

Thank you very much @albaintor

@albaintor
Copy link

Hi there, I am currently developing the new integration but since today I can't get access to the capabilities :
aiohttp.client_exceptions.ClientResponseError: 504, message='Gateway Timeout', url=URL('https://api.eu.ocp.electrolux.one/appliance/api/v2/appliances/<Appliance ID XXXXX>/capabilities')
Is this only me (my account is blocked temporarily or no) or is this for everyone ?

@standahabich
Copy link

standahabich commented Feb 1, 2024

the same problem

First occurred: 31. 01. 2024 v 20:02:47 (57 occurrences)
Last logged: 09:04:33

aiohttp.client_exceptions.ClientResponseError: 504, message='Gateway Timeout', url=URL('https://api.eu.ocp.electrolux.one/appliance/api/v2/appliances/***/capabilities')

access from browser:

{"Message":"User is not authorized to access this resource with an explicit deny"}

@Woyken
Copy link
Owner

Woyken commented Feb 1, 2024

504 sounds like their servers are having problems...

@albaintor
Copy link

albaintor commented Feb 1, 2024

I don't know how to get over this problem : I think they blocked somehow the access to this API (but not the listing and the state retrievals).
I guess that their server is overwhelmed by "us" : this integration (I mean the homeassistant integration) is not clean as it polls every few seconds the status of each appliance. This is the reason why I considered using the websocket API where data is pushed by their server only if something changes, but I didn't expect they blocked the extraction of capabilities which is necessary to build all the entities

@Woyken
Copy link
Owner

Woyken commented Feb 1, 2024

Their app is having problems loading for me today too....
Also response contains this:
image

It's totally their servers acting up.
I'd expect it to back to normal after a while

@albaintor
Copy link

albaintor commented Feb 1, 2024

Maybe their servers have problems but as @standahabich reported, I am not sure this will be possible again :
{"Message":"User is not authorized to access this resource with an explicit deny"}
EDIT : unless you just copied/paste the url in your browser without authentication credentials ?

@slingshot74
Copy link

@albaintor Can you still log into the app. When I try the integration for me there is the know error and because it keeps trying my account get blocked and I can't login into the app anymore, says it's blocked for awhile.
I then need to reset the password and after that I can login again.
The explicit deny may be because of this.

@wgumaa
Copy link
Author

wgumaa commented Feb 1, 2024

It's been intermittent all day including the Electrolux app.

Suggestion: why dont we move the conversation to @albaintor page as this is where its being worked on and not burden @Woyken! :)

@slingshot74
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants