Create dashboard #32
Create dashboard #32
Conversation
Create dashboard graphs
Merging to pull the first two graphs that Ryan made
Create dashboard layout
…abs/dashboard-project-group14 into create-dashboard-graphs
Create dashboard graphs
Create dashboard layout
There was a problem hiding this comment.
Some minor comments that should be pretty straightforward to fix and then a couple larger ones that have been put into issues #35 to be fixed in Milestone 4.
Only other general comment is to replace any instances of 'boardgame' with 'board game'.
app/dash_layout.py
Outdated
| from dash.dependencies import Input, Output, State | ||
| import dash_table | ||
|
|
||
| # import functions from Ryans .py files |
There was a problem hiding this comment.
should probably just say import functions from .py files
app/dash_layout.py
Outdated
|
|
||
| # title | ||
|
|
||
|
|
app/dash_layout.py
Outdated
| html.H5("Welcome to our Boardgames Dashboard"), | ||
| html.Div( | ||
| id="intro", | ||
| children="Explore boardgame trends over time based on category, mechanics and publisher selection below. Also visualize the top categories, mechanics and publishers by year using our interactive features.", |
There was a problem hiding this comment.
this should probably wrapped to multiple lines within the code. Also change to board game.
app/dash_layout.py
Outdated
|
|
||
| # lower description for tab 1 | ||
|
|
||
|
|
app/dash_layout.py
Outdated
| children=[ | ||
| html.H4("Description of Dataset"), | ||
| html.P( | ||
| " This dataset comes from the Board Game Geek website and includes boardgames with descriptions, general game details, publisher, and user ratings for 10,000 boardgames published between 1950 and 2021." |
| html.Br(), | ||
| html.Br(), | ||
| html.Br(), | ||
| ], |
There was a problem hiding this comment.
there's probably a better way to do lots of white space (maybe) but something to table for Milestone 4 - added to issues #35
app/dash_layout.py
Outdated
| 2000: "2000", | ||
| 2005: "2005", | ||
| 2010: "2010", | ||
| 2015: "2015", |
There was a problem hiding this comment.
recommend making a variable for this dictionary (higher up in the files) as it shows up again lower down
app/dash_layout.py
Outdated
| step=1, | ||
| value=[1990, 2010], | ||
| marks={ | ||
| 1950: "1950", |
| Output("output-container-range-slider-non-linear3", "srcDoc"), | ||
| Input("non-linear-range-slider", "value"), | ||
| ) | ||
| def update_output3(value): |
There was a problem hiding this comment.
the following series of functions appear to be all identical, should create a general function that can be called for each of these (added to issues #35 for Milestone 4)
In the interim should add a comment that indicates that we recognize this and will do this in Milestone 4 - we may also modify these bar charts, so not really worth trying to do as it may be removed anways!
app/dash_layout.py
Outdated
| return html.Div( | ||
| id="description-card", | ||
| children=[ | ||
| html.H5("Welcome to our Boardgames Dashboard"), |
| html.Div( | ||
| [ | ||
| html.H4("Board game ratings and counts from 1950 to 2016"), | ||
| html.P( |
| html.H4("Board game ratings and counts from 1950 to 2016"), | ||
| html.P( | ||
| "Select either categories, mechanics or publishers. Then select up to 5 different elements to view on figure 1 and 2." | ||
| ), |
There was a problem hiding this comment.
If not using figure numbers, replace the sentence as follows:
Then select up to 5 different elements to view on the following two figures.
app/dash_layout.py
Outdated
| [ | ||
| # tab 1 | ||
| dcc.Tab( | ||
| label="Game dynamics over time", |
| html.Label("Select what you want to view:"), | ||
| html.Br(), | ||
| dcc.RadioItems( | ||
| id="radio-selection", |
There was a problem hiding this comment.
should put a gap between the radio button and text (assume it's as simple as " Categories")
app/dash_layout.py
Outdated
| """ | ||
| return html.Div( | ||
| children=[ | ||
| html.H4("Top 5 categories, mechanics and publishers by rating"), |
app/dash_layout.py
Outdated
| """ | ||
| :return: A Div containing dashboard title. | ||
| """ | ||
| return html.Div(children=[html.H1("Boardgames Trends Dashboard")]) |
…abs/dashboard-project-group14 into create-dashboard-update
Create dashboard update
No description provided.