Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade master to the current wrensec-parent #48

Merged
merged 24 commits into from
Dec 5, 2022

Conversation

pavelhoral
Copy link
Member

Goal of this PR is to fix the build and update relevant dependencies.

Master is fully buildable, however there is issue with initial EmbeddedDS when configuring the AM.

Also the current master does not contain the newest changes that are somewhat prepared in #34 and #38? Modifications done in this PR were done completely independently from the mentioned PRs. So maybe the next step might be to rebase my work on top of Kortanul's original PRs?

@pavelhoral
Copy link
Member Author

pavelhoral commented Aug 1, 2021

I tried to play with #34 and that PR is unfortunatelly broken as there are obviously missing commits (e.g. package org.forgerock.openam.cts.continuous.watching). So the best way forward seems to be to make this PR work (if possible) and then port individual changes from #34/#38.

@pavelhoral pavelhoral assigned fyrbach and unassigned fyrbach Nov 30, 2022
@pavelhoral pavelhoral changed the title Upgrade master to the current wrensec-parent Make project buildable Nov 30, 2022
@pavelhoral pavelhoral changed the title Make project buildable Upgrade master to the current wrensec-parent Nov 30, 2022
Copy link
Member

@karelmaxa karelmaxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thank you.

@karelmaxa karelmaxa merged commit df0f2f1 into WrenSecurity:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants