Fix date format constant for version check. #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were you able to find where (by which commit) this inconsistency was introduced? Btw. commit message is missing issue number. |
minnoroth
force-pushed
the
fix-date-format-constant
branch
from
a1d7768
to
933133e
Compare
|
Updated the commit message with the number of the issue. The inconsistency was first introduced by this commit: |
|
Implemented changes does not feel complete - i.e. changing unit tests without checking what those tests are checking is suspicious. By a quick search you can find that the DATE_FORMAT constant is used in |
minnoroth
force-pushed
the
fix-date-format-constant
branch
from
6788f3c
to
95cebea
Compare
minnoroth
force-pushed
the
fix-date-format-constant
branch
from
95cebea
to
6e5227e
Compare
pavelhoral
force-pushed
the
fix-date-format-constant
branch
from
80d3dc4
to
9599887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
VERSION_DATE_FORMATconstant in order to prevent version check raising an exception:java.text.ParseException: Unparseable date: "2023-02-22T13:35:15Z"