Upgrade to Android 14 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional permissions are requested every 100 times the app is opened by the user.
User will now be able to navigate out of the activity even if all essential permissions have not been granted. RESULT_CANCELLED will be returned if all essential permissions have not been granted. RESULT_OK will be returned if all essential perms have been granted (notwithstanding status of non-essential perms).
- Permissions will be checked for and requested from onResume() rather than onCreate() - If essential perms are denied, app will close. - Removed `settingsActIsOver` fields as they seemed unnecessary.
- Renamed erstwhile `Service_UpdateAlarm` to `Service_SetAlarmsPostBoot` - Renamed erstwhile `Activity_RequestPerm` to `Activity_RequestPermIntro` - Modifications in the text shown in the activity
(for context-registered broadcast receivers)
The check for non-essential perms will now occur in the UI thread instead of background thread in Activity_AlarmsList. Reason: MutableLiveData.setValue() does not work in background threads, and we have to use postValue(). As a result, the value is actually not being set even after the thread finishes, and by that time, the activity is passing onResume(). If the app ever pauses and onResume() is called again, the perms. activity is suddenly launched. Hence, it is necessary to check for the non-essential perms in the main thread itself.
"Required" => if the chosen custom tone is not available or inaccessible.
KEEP IT THERE! This solves a bug wherein a NPE is thrown in `buildRingNotification()`.
This reverts commit 030ecde.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility update to Android 14!
Other changes: