This repository has been archived by the owner on Mar 2, 2022. It is now read-only.
fix build error #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chishiro, Thank you for trying out LegoOS. I took a quick look at the changes you made, I think some of them are valid, while some of them are "complains" from high version GCC. I will try it out today. |
lastweek
pushed a commit
that referenced
this pull request
Nov 7, 2018
We merge the compile error fix, which is described by pull request: #2 Higher version gcc catches several uninitialized local variables. Some of the affected code is dead code.
lastweek
pushed a commit
that referenced
this pull request
Nov 7, 2018
We merge the compile error fix, which is described by pull request 2: #2 Higher version gcc catches several uninitialized alocal variables. Some of the affected code is dead code. ilog_NaN may not work with high version GCC. So we reframe ilog2 a little bit.
|
I made some changes and merged most of your changes. I changed two things:
This complies with my platform. Not sure if gcc 7.4 will work. Let me know how it goes. |
|
@lastweek |
|
Sorry, I meant 7.3, the one you are using. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fix the build error in the following environments.
Please review my code.
The build error is caused by uninitiailized local values and undefined references.
Note that the modification of include/lego/log2.h may generate a build error in your environment.