Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original repository for hunspell #51

Closed
wants to merge 6 commits into from

Conversation

trofim24
Copy link
Contributor

@trofim24 trofim24 commented Dec 8, 2016

Use original repository for hunspell (https://github.com/hunspell/hunspell)
Current repository used for hunspell (https://github.com/nathanjsweet/hunspell-distributed) is not updated and is not supported for more than two years.

@nathanjsweet
Copy link
Collaborator

It's ultimately up to @Wulf, but I highly doubt this will get merged. Too many folks rely on buffers and NOT files (i.e. some people are using this project with a distributed database rather than a filesystem).

@nathanjsweet
Copy link
Collaborator

@trofim24 do you think you could spend time doing a merge request for https://github.com/nathanjsweet/hunspell-distributed to update it?

@trofim24
Copy link
Contributor Author

trofim24 commented Dec 9, 2016

@nathanjsweet and what hinders to write the buffer to a file?
https://nodejs.org/api/fs.html#fs_fs_write_fd_buffer_offset_length_position_callback

@nathanjsweet
Copy link
Collaborator

@trofim24 I did the work of adding a buffer interface to the main repository:
Here's the PR:
hunspell/hunspell#443
Once they mainline it I'll do the work of updating nodehun to use the main hunspell repo rather than my fork.
Thanks,
Nathan Sweet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants