Adding very basic support for #if/#endif #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#if / #endif wasn't handled at all. This changes it so includes inside an #if(def) block is ignored. (It would be 100 times better to tap into Intellisense's "Inactive Code". That or parse #ifdef:s properly. )
|
Thank you very much for your contribution! Ugh, this function gets really ugly now, need to clean this up at some point. But looks solid enough and as you're writing that should be okay for now, clearly better than the behaviour before that would just eat away ifdefed includes. Using intellisense for that sounds like a good idea. Since you recently pointed out that the CompilerTool apparently has some connection to IntelliSense already, this might be possible. Not super confident though. New issue #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code makes the TryError code ignore #if blocks.
Code like:
#if defined(WIN32)
#include <Windows.h>
#elif defined(LINUX)
#include <linux-only-file.h>
#endif
..did not work at all.
It would be a lot better to tap into intellisense:s "inactive code" for proper #if/#ifdef, or just write a proper parser.
This works for now, though. :)