-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for running the addin in VS2019 #68
Conversation
…6 implementation when required.
Why do you need to generate the vsix in 2017 when you ported the whole thing to 2019? |
I'm building on VS2017, but creating a version of the addin that works on VS2019 |
@Wumpf For what it's worth, I recently tried building it in 2017 (couple of months ago, now) and for the life of me I couldn't get it to work. I couldn't find a documented reason for it and everything seemed to be set up correctly. I was going to look at it but the only thing I could think to do is re-create the solution project-by-project. |
Probably depends on the update-version of 2017, haven't updated mine in quite a while. |
I don't think compatibility with previous versions was the problem, iirc it was the link-time inter-project dependencies. The vsix build step wanted to find DLLs somewhere they weren't, though there was absolutely zero indication anything was configured incorrectly. It was like a post-build copy of an output DLL wasn't happening in time for the vsix to build, despite all the project outputs and interdependencies being set correctly. Turning the build logs all the way up to max didn't help much, I could tell that was the case but there wasn't a reason for it. I did try recreating some of the projects, though there weren't any applicable differences between those and the original ones. It eventually (and I don't know how) managed to build, so I took the vsix and gave up trying to figure out why it didn't work most of the time. I had kind-of hoped maybe that problem would be resolved in 2019, but maybe it isn't. |
I managed to recreate the project in VS2019, got VSIX building and have it up and running in vs2019. Tbh I don't really understand what is different from what I tried previously :-/ ... @pjwhams hope you don't mind if I close your PR off and go with my version from here. Thanks for the effort, you definitely gently pushed me into looking at this sooner ;) |
Not at all! Thanks for keeping this project active. I'm trying to get back up to speed with writing VS addins after not touching them for a long time, so this was a useful refresher. |
For #67 - added some extra classes to enable use of the addin in VS2019. Unfortunately though I can't actually generate the .vsix file in VS2017 (the .dll builds ok, just doesn't generate the .vsix) so I'm unable to test it.