Fix MobSpawnESP NPE #470
Merged
Fix MobSpawnESP NPE #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After looking around further it looks like the array is cleared. It looks like an array.clear is called while the stream is busy, which results in an empty array, hence it becomes null. We could keep it like this with null check in the stream and it should work fine, I could also change it so the array won't be cleared if it's still busy and remove the null check, or add it on top of the null check. Not sure what the right course of action would be here. |
|
Thanks for looking into this -- hopefully it gets noticed, since being able to use MobSpawnESP without worrying about it crashing would make my life 10x easier. |
Alexander01998
added a commit
that referenced
this pull request
Oct 8, 2021
Alexander01998
added
type:bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue and possible duplicates?: #467 #442 #432 #233
After rigorously testing it seems that sometimes inside a stream map the variable is null, added null check.
Kept placing blocks mid air and destroying them in creative mode tons of times in quick succession, eventually game crashed with the exact same log from the related issue.