Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New settings to vclip command #645

Merged
merged 4 commits into from Jun 12, 2022
Merged

Conversation

C0derK1d
Copy link
Contributor

@C0derK1d C0derK1d commented May 7, 2022

Suggestion: #641.
Description:

.vclip above will automatically, vertically clip the player at the closest empty space above him.
.vclip below will automatically, vertically clip the player at the closest empty space below him.

     .vclip above: clips up to the nearest empty space above you
     .vclip below: clips down to the nearest empty space below you
@CLAassistant
Copy link

CLAassistant commented May 7, 2022

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link

ghost commented May 8, 2022

Could you change the way above vclipping works?

This way it always bumps the player 1 block above, unless you stick your head directly under a block.

A way I found to fix this, was to check if the next 10 blocks upwards are AIR and if one of them isn't to teleport the player above it.

@ghost
Copy link

ghost commented May 8, 2022

Also you could change the way the player is being teleported, to a more efficient and non-clunky one. Instead of teleporting the player to the position of the closest block, it should teleport the player to the height of the block, thus reducing clunkiness.

     The ".vclip above" only clips to the position if have a solid block under it
@Alexander01998 Alexander01998 added type:enhancement New feature or request category:movement area:command Adds or improves chat commands. labels Jun 11, 2022
@Alexander01998 Alexander01998 linked an issue Jun 11, 2022 that may be closed by this pull request
@Alexander01998 Alexander01998 added this to the v7.27 milestone Jun 12, 2022
Alexander01998 added a commit that referenced this pull request Jun 12, 2022
@Alexander01998 Alexander01998 merged commit 4a7089a into Wurst-Imperium:master Jun 12, 2022
@Alexander01998 Alexander01998 added the status:merged This pull request has been merged, even if GitHub says otherwise. label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:command Adds or improves chat commands. category:movement status:merged This pull request has been merged, even if GitHub says otherwise. type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] ".vclip above" and ".vclip below" commands.
3 participants