Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix X-Ray brightness reset #850

Merged
merged 3 commits into from Dec 14, 2023

Conversation

ThisTestUser
Copy link
Contributor

@ThisTestUser ThisTestUser commented Jun 25, 2023

X-Ray will now reset the brightness on disable if the fullbright mod is disabled and when the fullbright mod is enabled with night vision mode.

According to the Fullbright hack, if the gamma option is not chosen, the brightness is set to the default value indicated by the defaultGamma slider. It makes sense then to reset the brightness if fullbright is on but night vision is enabled.

Copy link

coderabbitai bot commented Dec 14, 2023

Walkthrough

Walkthrough

The updates in the FullbrightHack.java and XRayHack.java files involve enhancing the conditional logic related to the full brightness feature in a Minecraft client mod. A new method has been added to check if the gamma setting is used for full brightness, and the disabling behavior of the X-ray feature now considers whether both the full brightness hack and its gamma option are not active.

Changes

File Summary of Changes
.../hacks/FullbrightHack.java Added isGammaOption() method to determine if the gamma setting is used for full brightness.
.../hacks/XRayHack.java Modified onDisable method to include a check for the gamma option of the full brightness hack before disabling.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 125ebcd and 039584d.
Files selected for processing (2)
  • src/main/java/net/wurstclient/hacks/FullbrightHack.java (1 hunks)
  • src/main/java/net/wurstclient/hacks/XRayHack.java (1 hunks)
Additional comments: 2
src/main/java/net/wurstclient/hacks/FullbrightHack.java (2)
  • 166-169: The method isGammaOption() has been added as a public method. Verify if this method is intended to be part of the public API or if it should be private.

  • 168-168: The implementation of isGammaOption() correctly checks if the Fullbright mod's current method is set to gamma.

@Alexander01998 Alexander01998 added this to the v7.40 milestone Dec 14, 2023
@Alexander01998 Alexander01998 merged commit 039584d into Wurst-Imperium:master Dec 14, 2023
2 checks passed
Alexander01998 added a commit that referenced this pull request Dec 14, 2023
@Alexander01998 Alexander01998 added status:merged This pull request has been merged, even if GitHub says otherwise. and removed status:confirmed labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:render status:merged This pull request has been merged, even if GitHub says otherwise. type:bugfix This can be released as a patch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants