Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark-discord and tickets #22

Open
Stage4000 opened this issue Feb 7, 2023 · 8 comments
Open

dark-discord and tickets #22

Stage4000 opened this issue Feb 7, 2023 · 8 comments
Assignees
Labels
bug Something isn't working. in progress This is currently worked on.

Comments

@Stage4000
Copy link

Hey there just wanted you to know that viewing an open ticket with the discord dark theme is broken. The colors make it so its near impossible to read any of the contents of the page, for some reason table cells are white (or near white) with white text.

@Stage4000
Copy link
Author

I fixed this locally with some CSS jank.

@Stage4000
Copy link
Author

So after looking into this further, this might not be limited to the discord dark theme. It appears that the table that contains the support ticket has it's CSS set inline. I set all tables and all children of tables to have an important background color and this appears to be doing the trick.

@4yx
Copy link
Member

4yx commented Feb 7, 2023

Nice! Would you be able to open a PR and contribute the fix upstream?

@4yx 4yx self-assigned this Feb 7, 2023
@4yx 4yx added the bug Something isn't working. label Feb 7, 2023
@Stage4000
Copy link
Author

My changes aren't really... PR-able... I just added some raw CSS to my advert area to override the white background in the tickets table. I have not had a chance to thoroughly test that this fix doesn't cause cancer elsewhere since it is kind of broad CSS, but here it is.

<style>
.table>thead>tr>th, .table>tbody>tr>th, .table>tfoot>tr>th, .table>thead>tr>td, .table>tbody>tr>td, .table>tfoot>tr>td {
    padding:8px;
        background-color: #2c2f33 !important;
}
td{background-color: #2c2f33 !important;}
.table{background-color: #2c2f33 !important;}
</style>

@Stage4000
Copy link
Author

I don't actually think the middle clause is needed, you may want to test further. I think that the classes 1&3 are relevant though.

@Stage4000
Copy link
Author

Stage4000 commented Feb 7, 2023

I think adding background-color: #2c2f33 !important; as an insertion on line 485 of style.css might do the trick.

@4yx
Copy link
Member

4yx commented Feb 7, 2023

I'll test myself and apply a patch shortly; thank you for reporting this and highlighting where it can be applied!

@4yx 4yx added the in progress This is currently worked on. label Feb 7, 2023
@Stage4000
Copy link
Author

No lie, just spent an hour setting up an exact copy of your CDN and then testing edits.

@Stage4000 Stage4000 mentioned this issue Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. in progress This is currently worked on.
Projects
None yet
Development

No branches or pull requests

2 participants