Scripture Takes Flowpane

[KJoslyn]

TakesFlowPane now fills out the last row of take cards with blank take cards. When the alternate takes list is changed, or when the window is resized, blank cards are added or removed appropriately.

To test, either run main in Main.kt and drill down to a scripture takes page, or checkout takes-flowpane-testapp and run main in RecordScriptureTestApp, which brings you directly to the scripture takes page.

---

This change is 

[aunger]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @KJoslyn)

---

src/main/kotlin/org/wycliffeassociates/otter/jvm/app/ui/takemanagement/view/TakesFlowPane.kt, line 32 at r3 (raw file):

    override fun layoutChildren() {
        super.layoutChildren()
        if (!isStageShownProperty.value) {

Minor: Consider reversing if/else so predicate isn't negative

---

src/main/kotlin/org/wycliffeassociates/otter/jvm/app/ui/takemanagement/view/TakesFlowPane.kt, line 93 at r3 (raw file):

        // can easily overflow to a second row. In this case, we should underestimate the amount of space we have.
        if (getNonBlankChildren().size <= roundedMax &&
            nonRoundedMax - roundedMax < 0.02

Minor:
combine lines
also consider pulling return out of if/else

[aunger]

Reviewed 1 of 8 files at r1, 4 of 5 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @KJoslyn)

[aunger]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @KJoslyn)

[KJoslyn]

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @aunger)

---

src/main/kotlin/org/wycliffeassociates/otter/jvm/app/ui/takemanagement/view/TakesFlowPane.kt, line 32 at r3 (raw file):

Previously, aunger (Russell Aunger) wrote…

Minor: Consider reversing if/else so predicate isn't negative

Yep, that's better. Done.

---

src/main/kotlin/org/wycliffeassociates/otter/jvm/app/ui/takemanagement/view/TakesFlowPane.kt, line 93 at r3 (raw file):

Previously, aunger (Russell Aunger) wrote…

Minor:
combine lines
also consider pulling return out of if/else

Done.

[aunger]

Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved