-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapbox transition out of open source world #260
Comments
@HarelM What do you mean they are "transitioning out of free open source license"? I do not see anything in their new license agreement which would point me towards that conclusion. Granted, it is not BSD anymore, but it is still free to use for everyone. Am I wrong? Could you please elaborate? |
The internet is full of articles ranting about it :-) |
Can you point our a clause in their license which makes you think so? |
"Developers may modify the |
Well, what this clause says is that you cannot modify particular part of SDK. It does not say anything about using SDK without a mapbox token. That's how I understand it. I've read this yesterday and did not see anything particularly spooky for the library users :) I might be wrong here though. |
Its not totally clear to me because i have not tried yet, but mapbox 2.0 seems to require a token to initialize. Am i wrong here? |
What i can find so far here https://www.mapbox.com/legal/tos/: "When you use our application program interfaces (APIs), including our SDK Registry/Downloads API, each request to an API must include one of your account's unique API keys." So, indeed 2.0.0 will only work with mapbox's API keys. We'll see what this really means in the future. What @HarelM suggests makes sense. Though, i'm not sure if it's a good idea to have this wrapper work with both mapbox >= 2.0.0 and some other OSS fork. Over time they will diverge and support will become a nightmare. So, my gut reflex would be to fork this lib to use with any OSS alternatives out there. Let's not make any rush decisions though :) |
No problem, just wanted to start a discussion and let you guys know of the recent news :-) |
Thanks for the head up. I saw the 2.0.0 release briefly but didn't noticed this big licensing change. Let's wait and see for now... Edit: yep, it does not work anymore without a token: https://stackblitz.com/edit/ngx-mapbox-gl-without-token-hmicn6 |
It seems 2020 don't want to end with good news lol Every company now wants to get money in any way! It seems good days are no more. |
@Wykks I think it is not much to do here. If someone wants to fork this repo and start supporting maplibre, that's okay. But I highly doubt this library will support it. Maybe we should just close this issue. |
I don't mind forking and helping maintain the maplibre fork but I was hoping you guys would join me there... If this is not the direction you would like to pursue that totally fine! I mainly wanted to know where you stand. |
@HarelM IMO, the libs will inevitably diverge and maintaining single wrapper for both will become harder and harder over time (error-prone and so on). That being said, if at some point our company decides to switch to maplibre, I will definitely come to help with a wrapper for it. |
Fair enough. My initial assumption is that there won't be a single wrapper, but rather two wrappers each for each library - as I agree that maintaining a single wrapper for both will become harder or not possible over time. |
Closing the issue for now. Let's re-visit this when (if) the need arises |
For anyone reading this in the future, I've started a fork to support maplibre here: |
It seems that Mapbox is transitioning out of free open source license.
There's a project now forming around the open source port of this:
https://github.com/maplibre
It might be nice to have this project there and reference the open source version of mapbox (maplibre).
Another option is to allow dependencies of one of the projects - maplibre and mapbox and avoid warning in NPM when installing it.
The text was updated successfully, but these errors were encountered: