Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #2

Closed
HarelM opened this issue Jun 16, 2021 · 4 comments
Closed

Fix tests #2

HarelM opened this issue Jun 16, 2021 · 4 comments

Comments

@HarelM
Copy link
Member

HarelM commented Jun 16, 2021

e2e tests are currently broken since I don't have the right map sources to showcase all the options and so the tests fail.
I would like to release an initial version to npm to see that it is working as expected and later on fix these tests...

@HarelM
Copy link
Member Author

HarelM commented Jun 21, 2021

@klokan any chance to get your help on this?
The purpose of the showcase is to demonstrate maplibre-gl and ngx-maplire on top of it.
What I basically need are some styles json file stored remotely I can use for the demo pages, I currently use only the streets.json, the same one from the maplibre examples, but I would like to showcase other styles if it's OK by you.

@klokan
Copy link
Member

klokan commented Jun 21, 2021

Looks as a great effort! Thanks for pushing on this.

  • Are the demos going to be displayed only on maplibre.org?
    (BTW do you know that if you make a gh-pages branch for the web pages in any of the maplibre repos - your webpages pushed there are going to be available at http://maplibre.org/ngx-maplibre-gl/ - similarly as https://maplibre.org/maplibre-gl-js-docs/ is?)

  • Why is this repo only a fork? If you want to make it the official Angular binding for maplibre - just propose a transfer.

  • Don't you want to join this Wednesday on the steering commity meetup to do a demo and show it off?

@HarelM
Copy link
Member Author

HarelM commented Jun 21, 2021

Thanks for the quick response!

  • I haven't got to the point where I though about where to host the documentation, but gh-page was one of my first thoughts, if it is displayed at maplibre.org it would be great (I didn't know that).
  • The original code was not maintained by me and I did try to move the maintainers here, but I guess they are using mapbox so they preferred to stay there. You can read more about it here: Mapbox transition out of open source world Wykks/ngx-mapbox-gl#260
  • I'll be joining the Wednesday meeting (hopefully if everything goes as planned), I can probably do a short demo there if there aren't more urgent topics to discuss...

But first thing first, I need to fix the tests, and for that I need a few more styles to be able to switch between them in one of the showcases.

HarelM added a commit that referenced this issue Jun 23, 2021
@HarelM
Copy link
Member Author

HarelM commented Jun 23, 2021

Test that still fail:

  • popup-on-click - icon theatre-15 ??
  • 3d-buildings - source "composite" not found
  • Toggle layers - contours and museums sources - not sure how to easily fix this

@HarelM HarelM closed this as completed in a9a91be Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants