perf: Optimize ItemHandler lore soft matching [skip ci] (#2440)

common/src/main/java/com/wynntils/handlers/item/ItemHandler.java

@@ -1,5 +1,5 @@
 /*
- * Copyright © Wynntils 2022-2023.
+ * Copyright © Wynntils 2022-2024.
  * This file is released under LGPLv3. See LICENSE for full license details.
  */
 package com.wynntils.handlers.item;
@@ -23,10 +23,12 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Optional;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import net.minecraft.core.NonNullList;
+import net.minecraft.nbt.ListTag;
 import net.minecraft.world.item.Item;
 import net.minecraft.world.item.ItemStack;
 import net.minecraft.world.item.Items;
@@ -218,10 +220,16 @@ private boolean isWildcardItem(ItemStack itemStack) {
      * It might have additional lines added, but these are not checked.
      */
     private boolean isLoreSoftMatching(ItemStack firstItem, ItemStack secondItem) {
-        List<StyledText> firstLines = LoreUtils.getLore(firstItem);
-        List<StyledText> secondLines = LoreUtils.getLore(secondItem);
-        int firstLinesLen = firstLines.size();
-        int secondLinesLen = secondLines.size();
+        ListTag firstLoreTags = LoreUtils.getLoreTag(firstItem);
+        ListTag secondLoreTags = LoreUtils.getLoreTag(secondItem);
+
+        // Tags implement equals, so we can use this to check if the lore is identical
+        // This is the most common short-circuit case
+        if (Objects.equals(firstLoreTags, secondLoreTags)) return true;
+
+        // Continue, as we allow 3 lines to differ
+        int firstLinesLen = firstLoreTags.size();
+        int secondLinesLen = secondLoreTags.size();
 
         // Only allow a maximum number of additional lines in the longer tooltip
         if (Math.abs(firstLinesLen - secondLinesLen) > 3) return false;
@@ -231,8 +239,8 @@ private boolean isLoreSoftMatching(ItemStack firstItem, ItemStack secondItem) {
         if (linesToCheck < 3 && firstLinesLen != secondLinesLen) return false;
 
         for (int i = 0; i < linesToCheck; i++) {
-            StyledText firstLine = firstLines.get(i);
-            StyledText secondLine = secondLines.get(i);
+            StyledText firstLine = StyledText.fromJson(firstLoreTags.get(i).getAsString());
+            StyledText secondLine = StyledText.fromJson(secondLoreTags.get(i).getAsString());
 
             if (!firstLine.equals(secondLine)) return false;
         }