Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TeleportScrollProperty crashes on scrolls for the Forgery #242

Closed
HighCrit opened this issue Aug 7, 2022 · 0 comments · Fixed by #249
Closed

TeleportScrollProperty crashes on scrolls for the Forgery #242

HighCrit opened this issue Aug 7, 2022 · 0 comments · Fixed by #249

Comments

@HighCrit
Copy link
Member

HighCrit commented Aug 7, 2022

image
With java.lang.StringIndexOutOfBoundsException: begin 0, end 2, length 1 at line

Artemis/common/src/main/java/com/wynntils/wc/custom/item/properties/TeleportScrollProperty.java

Line 66 in 3e2af90

location = location.substring(0, 2);

HighCrit added a commit that referenced this issue Aug 7, 2022
@HighCrit
Fix itemproperty crash on the Forgery tp scrolls
1c7554e 
Fixes #242 by moving the substring method to the block for towns. As the Dungeon block  can already only produce strings upto 2 chars and all towns have at least 2 chars.
@HighCrit HighCrit mentioned this issue Aug 7, 2022
Merged
HighCrit added a commit that referenced this issue Aug 7, 2022
@HighCrit
Fix itemproperty crash on the Forgery tp scrolls (#249)
5adeef1 
Fixes #242 by moving the substring method to the block for towns. As the Dungeon block  can already only produce strings upto 2 chars and all towns have at least 2 chars.
Kepler-17c pushed a commit to Kepler-17c/Artemis that referenced this issue Aug 12, 2022
@HighCrit @Kepler-17c
Fix itemproperty crash on the Forgery tp scrolls (Wynntils#249)
8a1b4f9 
Fixes Wynntils#242 by moving the substring method to the block for towns. As the Dungeon block  can already only produce strings upto 2 chars and all towns have at least 2 chars.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix itemproperty crash on the Forgery tp scrolls Wynntils/Artemis
1 participant
@HighCrit