perf: Optimize ItemHandler lore soft matching #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCat117
approved these changes
Apr 29, 2024
magicus
approved these changes
Apr 30, 2024
kristofbolyai
added a commit
that referenced
this pull request
May 5, 2024
kristofbolyai
added a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I am starting a new branch, to collect some performance patches, I'll be working on in the upcoming days.
Test
Join the same 5 classes, in order, then open the trade market, and scroll 10 pages.
Results
Verification
Ran the old and new algorithm side-by-side, performed the same tests as the benchmark, no assertions triggered (the two methods produced identical results).