Overlays: Add health bar and mana bar overlays #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicus
reviewed
Jul 25, 2022
magicus
reviewed
Jul 25, 2022
common/src/main/java/com/wynntils/features/user/overlays/CustomBarsFeature.java
Outdated
Show resolved
Hide resolved
magicus
reviewed
Jul 25, 2022
magicus
reviewed
Jul 25, 2022
magicus
reviewed
Jul 25, 2022
magicus
approved these changes
Jul 26, 2022
Closed
magicus
pushed a commit
to magicus/Artemis
that referenced
this pull request
Jul 28, 2022
* Overlays: Add CustomBarsFeature (health bar) * Overlays: Add CustomBarsFeature (health and mana bar) * Mixins: Fix forge gui mixins * Overlays: Fix field naming * RenderUtils: Refactor drawProgressBar
Kepler-17c
pushed a commit
to Kepler-17c/Artemis
that referenced
this pull request
Aug 12, 2022
* Overlays: Add CustomBarsFeature (health bar) * Overlays: Add CustomBarsFeature (health and mana bar) * Mixins: Fix forge gui mixins * Overlays: Fix field naming * RenderUtils: Refactor drawProgressBar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds health and mana bar overlays. These are the first replacement overlays, they seem to work fine. Tested it with forge and fabric, and I applied the forge specific fixes.
Fill animations are missing compared to legacy, they can be added later, this is just a base for improvement (basically changes are instant and not animated).
Example:
