WIP: Hacks needed to try out the new mapdata system #2159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
kristofbolyai
force-pushed
the
main
branch
4 times, most recently
from
6c6f9fc
to
1c6c3d8
Compare
kristofbolyai
force-pushed
the
mapdata-part-2
branch
from
4e587a2
to
f795825
Compare
…tom (dynamic only) and json-parsed map visibility
…and also add a missing local-file provider loading method)
This is re-created from Wynntils#2375
This is needed in the future to properly implement visibility based on zoom level.
magicus
added a commit
to magicus/Artemis
that referenced
this pull request
May 13, 2024
This supersedes Wynntils#2159
|
Superseded by #2490. |
magicus
added a commit
to magicus/Artemis
that referenced
this pull request
May 13, 2024
This supersedes Wynntils#2159
magicus
added a commit
to magicus/Artemis
that referenced
this pull request
May 13, 2024
This supersedes Wynntils#2159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really based on #2158. Here are some hacky extensions that will allow you to actually use and play around with the new mapdata system.
There is also documentation (in the hijacked README file) with what I believe remains to be done, and various design notes (mostly for my own memory).