Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance assertions #21

Merged
merged 1 commit into from Jan 18, 2019
Merged

Enhance assertions #21

merged 1 commit into from Jan 18, 2019

Conversation

peter279k
Copy link
Contributor

Changed log

  • Using the ::class method for all classes in tests folder.
  • Remove error assertion because the Exception::$code is the protected variable ant this cannot access via inherited class.

@peter279k
Copy link
Contributor Author

Although the Travis CI build is failed during php-nightly build, my Travis CI build for forked repo is successful.

@WyriHaximus
Copy link
Owner

Just kicked that job and it's doing fine now

@WyriHaximus WyriHaximus merged commit 2fafb14 into WyriHaximus:master Jan 18, 2019
@WyriHaximus
Copy link
Owner

WyriHaximus commented Jan 18, 2019 •
edited

These PR's are much appreciated, thank you 👍 !

@peter279k peter279k deleted the enhance_assertions branch January 19, 2019 00:38
@WyriHaximus WyriHaximus added this to the 3.0.0 milestone Jul 17, 2020
@WyriHaximus WyriHaximus added PHP 🐘 Hypertext Pre Processor Tests 🧪 labels Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PHP 🐘 Hypertext Pre Processor Tests 🧪
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peter279k @WyriHaximus