Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target PHP 8 in composer.json #55

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Conversation

Ahmard
Copy link
Contributor

@Ahmard Ahmard commented Dec 15, 2020

Add support to PHP 8

Copy link
Owner

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.json looks good, but composer.lock is outdated, could you update that?

Also it looks like there is more to be updated. When I just tried to run it on PHP 8 nothing happened. So this would be a first step to PHP 8 support tbh

@@ -44,6 +44,9 @@
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the error message on all travis jobs, this composer.lock file is not up to date with composer.json. For example: https://travis-ci.com/github/WyriHaximus/reactphp-child-process-pool/jobs/460266452#L216

Can you fix that?

@WyriHaximus
Copy link
Owner

Thanks for the update, at least it installs now on PHP 7.x.

On PHP 8.x (nightly) it can't because not all dependencies have been updated yet to support PHP 8. So at least https://github.com/WyriHaximus/reactphp-child-process-messenger has to be updated. Already working on the CPU core count detector. Maybe one or two more packages also need updates before this one also works.

@WyriHaximus WyriHaximus mentioned this pull request Jan 10, 2021
@WyriHaximus WyriHaximus changed the title PHP 8 suppport added Target PHP 8 in composer.json Mar 14, 2021
Copy link
Owner

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this only unlocks future PHP 8 support in this package, dependencies are as good as ready to be tagged with PHP 8 support, and thus this package should also have it very soon.

@WyriHaximus WyriHaximus merged commit 94655c7 into WyriHaximus:master Mar 14, 2021
@WyriHaximus WyriHaximus added this to the 1.7.0 milestone Mar 14, 2021
@WyriHaximus WyriHaximus added the Enhancement ✨ New feature or request label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants