Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挭馃К amino acid and nucleotide filters #39

Merged
merged 3 commits into from
Feb 23, 2023
Merged

馃挭馃К amino acid and nucleotide filters #39

merged 3 commits into from
Feb 23, 2023

Conversation

TKMarkCheng
Copy link
Contributor

Adding filter by a series of amino acid and/or nucleotide mutations by entering a string with comma-separated substitutions/mutations.

Also added to the README.md, as internal_query.R in addition to query.R needs to be updated for new filters to operate.

@TKMarkCheng TKMarkCheng changed the title The addition of amino acid and nucleotide filters 馃挭馃К amino acid and nucleotide filters Feb 21, 2023
@BryanTegomoh
Copy link

certainly a useful addition to the query function

@TKMarkCheng
Copy link
Contributor Author

@Wytamma, please can I ask if this can be built tested, and merged? R CMD check via devtools::check() worked and passed all test locally and I am bursting with excitement to contribute to this project!
use aa_substitution and nucl_mutation to filter on mutations of interest.

df <- query (credentials = credentials, aa_substitution = 'Spike_H69del, Spike_A222V, Spike_G476S, -N_P13L')
expect_equal(df$submission_date[1], "2021-04-27") #earliest is 2021-04-27

@Wytamma
Copy link
Owner

Wytamma commented Feb 23, 2023

Hey @TKMarkCheng! That鈥檚 amazing thanks heaps! Sorry have been traveling will merge your PR asap!

@Wytamma
Copy link
Owner

Wytamma commented Feb 23, 2023

I can鈥檛 run the tests on the PR because the worker doesn鈥檛 have access to the repo secrets. But the code looks good so I鈥檒l just merge and run them on main.

@Wytamma Wytamma merged commit e11f2b8 into Wytamma:master Feb 23, 2023
@TKMarkCheng
Copy link
Contributor Author

@Wytamma happy to contribute! I am in fact glad that I had an extra day to catch that incompatibility issue with load_all. Hopefully, this PR can act as a template for future contributors.

I presume the repo secrets are the GISAIDR_USERNAME and GISAIDR_PASSWORD stored on local .Renviron, so would be not fixable unless the worker itself has an equivalent to .Renviron file.

@Wytamma
Copy link
Owner

Wytamma commented Feb 23, 2023

Nah it鈥檚 a security reason. GitHub prevents PRs from other people from accessing the env vars so that you can鈥檛 steal my gisaid password etc. But looks like it all worked! Congratulations and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants