Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Remove unused Monero miner from xcashd (and simple_wallet/rpc commands) #25

Closed
ghost opened this issue Dec 3, 2021 · 1 comment
Labels
◼ Type: Enhancement This issue relates to a feature/improvement of a feature.

Comments

@ghost
Copy link

ghost commented Dec 3, 2021

The inherited Monero CPU miner built into the daemon source code has not been realistically usable for years and triggers Anti-Virus software when the binaries are downloaded.

Expected Behavior
All traces of the Monero miner should be removed to prevent triggering an anti-virus block. With luck, removing the miner will allow users to install the wallet without any issues with the myriad of installed AV products.

Current Behavior
The unused Monero CPU miner code is embedded into the current xcashd binary.

Possible Solution
If no miner source code is used in DPOPS block creation, then the entire miner object source code should be removed from the project to avoid adding code that will be flagged by AV software. Any code that may be used should be migrated into a DPOPS specific object that hopefully will not trigger AV catches.

Context
I do not see issues in Ubuntu since AV tools are generally less intrusive on Linux desktops, but I have seen several complaints in discord from the wallets being blocked from within Windows. I would be willing to do some research to provide suggested methods to excise this code if needed.

@ghost ghost added the ◼ Type: Enhancement This issue relates to a feature/improvement of a feature. label Dec 3, 2021
@zachhildreth
Copy link
Member

@CygnusMiner This is actually a really great idea! I think you mentioned it before but yes I would like a github issue on it as it reminds me and somehow gets me to do it faster lol

I think it is doable because the actual miner program is never used. I might also remove some rpc commands as well that are not used on the mining part.

zachhildreth added a commit that referenced this issue Mar 23, 2022
Try to remove more mining code, releated to issue #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
◼ Type: Enhancement This issue relates to a feature/improvement of a feature.
Projects
None yet
Development

No branches or pull requests

1 participant