Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template survival module #176

Closed
wants to merge 1 commit into from
Closed

template survival module #176

wants to merge 1 commit into from

Conversation

PhilipDeegan
Copy link
Member

@Mbompr
Copy link
Contributor

Mbompr commented Feb 13, 2018 •
edited

Was it necessary to also template ModelSCCS? I'm a bit afraid that this would lead to very bad conflicts with #158 ...
@MaryanMorel

@PhilipDeegan
Copy link
Member Author

understandable - yet templating half the module seemed a bit peculiar

we'll see what Maryan thinks, I've not changed any functionality.

@MaryanMorel
Copy link
Member

You're just using templating to allow multiple datatypes for coeffs in ModelSCCS right? In this case, it seems ok

@MaryanMorel
Copy link
Member

The rebase won't be that hard regaring ModelSCCS I think

@PhilipDeegan
Copy link
Member Author

PhilipDeegan commented Feb 13, 2018 •
edited

I'll revert SCCS and update it after you have merged to be safe - only need coxreg really

@PhilipDeegan PhilipDeegan deleted the template_survival branch February 14, 2018 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mbompr Mbompr Awaiting requested review from Mbompr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PhilipDeegan @Mbompr @MaryanMorel