Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggles for exporting only Solid or only non Solid LevelItem geo #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shadowth117
Copy link
Member

Wanted to add a way for SALVL to be able to export only visible or collision geo.

@ItsEasyActually
Copy link
Contributor

This is fine after testing, but I think the names for the options in the dropdown should be modified. The naming works for great for SA2, but it's lacking for SA1/DX. A suggestion would be to set the names to:

  • Only Export Visible Geometry
  • Only Export Non-Visible Geometry

Keeps consistency with the way the display options already work, and is accurate for both games. A tooltip can be more in-depth on how non-visible is generally collision and visible geometry is in SA1/DX only.

Another option is using the SA2 check. In the internal salvlini variable, we have an "isSA2" bool you could use. I think it'd be fine to use that to change the option names depending on what's loaded at the time.

@pkr-sadx
Copy link

If the names are changed, the code should also be changed to check for the "Visible" flag instead because not all visible geometry is solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants