Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

249: Convert Workflows #381

Closed
tngreene opened this issue Sep 6, 2018 · 6 comments
Closed

249: Convert Workflows #381

tngreene opened this issue Sep 6, 2018 · 6 comments
Assignees
Labels
2.49 Converter Bugs/Features related to the 2.49 Converter priority high

Comments

@tngreene
Copy link
Contributor

tngreene commented Sep 6, 2018

2.49 had 2 distinct workflows (we care about) and used Blender Objects in certain ways to achieve their means, we have something similar (but not a 1:1). We're going to need to convert the workflow so this works and ask users what they meant (if we can't guess ourselves) whether they used Bulk Export or Regular.

@tngreene tngreene added the 2.49 Converter Bugs/Features related to the 2.49 Converter label Sep 6, 2018
@tngreene tngreene self-assigned this Sep 6, 2018
@tngreene tngreene changed the title Convert Empties named "OBJ_" + name, at (0,0,0) into Root Object 249: Convert Empties named "OBJ_" + name, at (0,0,0) into Root Objects Sep 6, 2018
@tngreene tngreene changed the title 249: Convert Empties named "OBJ_" + name, at (0,0,0) into Root Objects 249: Convert Workflows Jan 18, 2019
@tngreene
Copy link
Contributor Author

See here for more details as we research: Workflow Translations

@tngreene
Copy link
Contributor Author

Converting and unit testing!

@tngreene
Copy link
Contributor Author

tngreene commented Feb 21, 2019

If you have multiple scenes, the naming works differently in regular mode. With one scene, it is the file name. With multiple it is the Scene name. We'll need multiple 249_NEW_ROOT empties with different names for this.

@tngreene tngreene reopened this Feb 21, 2019
@tngreene
Copy link
Contributor Author

Closes with dbb5971

@tngreene
Copy link
Contributor Author

Currently the API is not consistent, some sub converters take all the objects in a scene, some take new root objects which get searched (which breaks SKIP work flows), some take all objects period. In addition, some return a list of objects created, a list of objects touched, true or false if there was problem. (Could be messing up my memory, but just look at it).

SKIP needs to work, and I think there should be some consistency or more thought into what these return. There is the principle of "You aren't going to need it", but, something sensible should be done

@tngreene tngreene reopened this Apr 10, 2019
@tngreene
Copy link
Contributor Author

Since the ability to SKIP has been decided to remove, we are ready to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.49 Converter Bugs/Features related to the 2.49 Converter priority high
Projects
None yet
Development

No branches or pull requests

1 participant