Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

249: Remove SKIP workflow code and fix unit tests, API #440

Open
3 tasks
tngreene opened this issue Jul 17, 2019 · 1 comment
Open
3 tasks

249: Remove SKIP workflow code and fix unit tests, API #440

tngreene opened this issue Jul 17, 2019 · 1 comment
Assignees

Comments

@tngreene
Copy link
Contributor

tngreene commented Jul 17, 2019

SKIP workflow was a bad idea, now canceled. We need to remove the code (small) and change some of the early unit tests that were counting on it to use REGULAR or BULK (medium).

  • Remove SKIP related code
  • Change early tests that were counting on it to use REGULAR or BULK
  • Change APIs so they can assume there will always be a root object, code clean up (this point especially important)

See #381 for where this came from

@tngreene tngreene self-assigned this Jul 17, 2019
@tngreene tngreene added this to the 2.49 Converter v1.0-alpha.1 milestone Jul 17, 2019
@tngreene
Copy link
Contributor Author

Should the policy be "convert as many things as possible, unless dependent on Root Object?"

After seeing the amount of work sometimes not currently under a root object as a "rough draft, don't export" solution it would be really terrible to not have this work converted as well.

Hundreds of mesh's and material's unsplit, and lights unconverted for no reason that the user may someday want again. Texture conversion absolutely needs to start from the root down, but the others I see no reason why we shouldn't be going by per datablock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant