Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursion fix for sub nodes loop #15

Merged
merged 5 commits into from
Nov 26, 2023

Conversation

avisihag
Copy link
Contributor

@avisihag avisihag commented Nov 23, 2023

Description

@avisihag avisihag marked this pull request as ready for review November 23, 2023 09:44
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2) {
if (traversedNodes.contains(node)) return;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The override gives me confidence that this should work well.
image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I don't have a way of replicating the issue on demand

@X-SLAYER X-SLAYER merged commit e09b1ec into X-SLAYER:main Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants