Bogus warning about ambiguous method

[cpyrgas]

Following code (taken from real user code) reports 2 warnings:

warning XS9043: 'Equals' is ambiguous. Could be Method 'TestClass.Equals(int)' in xRuntime or Method 'object.Equals(object)' in mscorlib. Using the first one.
warning XS9043: 'Equals' is ambiguous. Could be Method 'AnotherClass.Equals(AnotherClass)' in xRuntime or Method 'object.Equals(object)' in mscorlib. Using the first one.

bu there's no ambiguity, the child method defines the parameter with the same type that is passed to it, so this is the one that should laways be picked. Same code in c# does not report any errors or warnings.

FUNCTION Start() AS VOID
	LOCAL o := TestClass{} AS TestClass
	o:Equals(123)
	
	LOCAL a := AnotherClass{} AS AnotherClass
	a:Equals(a)
RETURN

CLASS TestClass
	METHOD Equals(n AS INT) AS LOGIC
		? "called child"
	RETURN TRUE
END CLASS

CLASS AnotherClass
	METHOD Equals(o AS AnotherClass) AS LOGIC
		? "called child"
	RETURN TRUE
END CLASS

[cpyrgas]

Problem does not exist in Core dialect

[cpyrgas]

I'm still getting this one. Robert, I think you cheated by changing the test's Dialect to Core :)

[cpyrgas]

Just adding another case, as reported in https://www.xsharp.eu/forum/private-product/3329-2-14-0-4-compiler-errors-xs0121-and-xs1503#25003. Will test the updated compiler afterwards.

CLASS TestClass
END CLASS

CLASS Parent
VIRTUAL METHOD Add(o AS OBJECT) AS INT
RETURN 0
END CLASS

CLASS Child INHERIT Parent
METHOD Add(o AS TestClass) AS VOID
END CLASS

CLASS MyCollection INHERIT System.Collections.ArrayList
	METHOD Add(o AS TestClass) AS VOID
END CLASS

FUNCTION Start() AS VOID
	LOCAL t := NULL AS TestClass

	Child{}:Add(t) // no warning, OK
	
	MyCollection{}:Add(t) // warning XS9043: 'Add' is ambiguous. Could be Method 'MyCollection.Add(TestClass)' in xRuntime or Method 'System.Collections.ArrayList.Add(object)' in mscorlib. Using the first one.
RETURN

[cpyrgas]

Confirmed fixed