[KERNAL] ioinit now disables interrupt sources #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fulgen301
approved these changes
Jun 18, 2024
|
As a side note: it might be good to add some notes to the docs somewhere to suggest a custom BRK/NMI handler for user programs that enable add-on hardware IRQ sources, such as serial cards, so that they may disable the IRQ source, then chain to the default handler to allow the monitor or warm basic start to function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the C64,
ioinitdisables interrupt sources entirely, untilcintenables the default one. After this change, the same thing now happens on the X16.Ultimately, this allows the default NMI and BRK handlers to successfully give control to the user (in BASIC or MONITOR) even when the interrupted program uses VIA timers, LINE interrupts, YM2151 IRQs, or other IRQ sources on VERA.