Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup Screen Lock bug - Unable to enter password #194

Closed
Johnnybyzhang opened this issue Apr 21, 2024 · 3 comments · Fixed by #202
Closed

Followup Screen Lock bug - Unable to enter password #194

Johnnybyzhang opened this issue Apr 21, 2024 · 3 comments · Fixed by #202
Labels
bug Something isn't working

Comments

@Johnnybyzhang
Copy link

Describe the bug
This is a follow-up for #126 As the approach that fixed the keypad overlay issue has worsened it. When I wake the printer from sleep by pressing the power button or tapping on the screen, the password keypad then shows up, except that I am now unable to enter a passcode. I will attach a video showing this very issue.

To Reproduce
Steps to reproduce the behavior:

  1. Have a password set and update to X1Plus Version 1.1
  2. Press the power button to wait to put the printer to sleep
  3. Wake the printer from sleep by pressing the power button/tapping the screen
  4. The keypad will show up and one is unable to enter the password

Expected behavior
The lock screen should show up, having the password screen should also be an option (if applicable), but having the keypad while not being able to use it is clearly incorrect.

Screenshots/Photos

IMG_2345.mp4

External Links
This is a follow-up to #126 which is now closed but I believe it is still related.

Additional Details:

  • Printer type (X1/X1C/X1E): X1C
  • X1Plus version: 1.1
  • AP firmware version: 00.00.28.59
  • AP hardware revision: AP05
  • MC firmware version: 00.00.22.41
  • MC hardware revision: MC07
  • Toolhead firmware version: 00.00.07.12
  • Toolhead hardware revision: TH09
  • Computer vision model:

Is the bug present on OEM firmware?
Have you tested whether this bug is also present in OEM firmware?
If it is, which version? ex. 01.07.02.00
Are any steps to replicate it different?

Not possible in OEM

Custom modifications

None

Additional context
Update: I have restarted the screen service in an attempt to get snapshots, but it seems to have fixed the issue. I can still help by providing logs.

@Johnnybyzhang Johnnybyzhang added the bug Something isn't working label Apr 21, 2024
@jwise
Copy link
Member

jwise commented Apr 21, 2024

Whoah, interesting. Thanks for the detailed report. Is this the first time you’ve seen this, or does it happen regularly? I will stare harder at the code for this to see if I can understand how this could happen.

@Johnnybyzhang
Copy link
Author

Update: The reproduction method is the same as in #126, spamming the swipe to unlock is the reason to this very bug, just that it have a smaller impact

@Johnnybyzhang
Copy link
Author

IMG_2348.mp4

jwise added a commit that referenced this issue Apr 23, 2024
…sure that we do not pop a box multiple times (fixes #194)
jwise added a commit that referenced this issue Apr 24, 2024
…sure that we do not pop a box multiple times (fixes #194) (#202)

There were a handful of ways that the screen lock could go wrong. We shore up many of them:

* The StackView apparently did not work at all when we tried to pop from it. We give it a dummy item so that it is permitted to pop.
* If you somehow manage to tap behind the number pad without dismissing it, it would be good to make sure that the thumb is not draggable.
* If you somehow manage to tap the number pad and drag the thumb, it would be good to avoid popping the number pad twice.

Also, the tap handler leaked through!

Hopefully this fixes #194 once and for all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants