Add initial translations for Russian and Japanese #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riptidewave93
approved these changes
Mar 31, 2024
|
@jwise if we add the .qm files to the root.qrc of kexec_ui, then kexec_ui loads in whatever language is saved in printer.json otherwise kexec_ui doesn't translate into any other languages |
|
Yeah, I'll do that in a separate PR. |
|
An off-topic comment has been removed from this pull request. (This removal does not express an opinion on the contents of the removed comment, but only whether it is appropriate for this space.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Henry Thomasino (@ecycorin) and Jun (@jun_270) for their hard work on translations!