Introduce DBus-powered x1plusd to manage settings #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds our python service which will later house multiple DDS interfaces. To start, we have a settings engine other things, such as our OTA engine, can use.
* Remove get settings * remove usage of set as a var * added a catch-all for an invalid command * Renamed things to x1plusd * Better file handling logic * Exception handling on main loop
riptidewave93
approved these changes
Apr 28, 2024
…omic rename; only set new settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing in the path of #196, we introduce a handful of infrastructure in this PR, and only a few tiny users :-) The core idea of this is that we introduce @riptidewave93 's
x1plusd(and the associatedsettingsservice), but instead of binding it to DDS, we bind it to DBus usingjeepney(which @jphannifan found after I spent a night unsuccessfully wrestling with the library dependencies fordasbus-- thanks!). Thex1plusdregisters a DBus bus namex1plus.x1plusdthat has an object/x1plus/settings, which, in turn, exposes the following methods:x1plus.settings.GetSettings(json: string)returns a JSON dictionary of all the current known X1Plus settings, loaded from the SD card's printer-specific X1Plus settings JSON.x1plus.settings.PutSettings(json: string)updates the X1Plus settings with keys from the passed JSON dictionary.When a setting changes, it emits a signal:
x1plus.settings.SettingsChanged(json: string), with a dictionary that has set in it only the keys that have changed.We also introduce a QML API,
X1Plus.Settings.get/X1Plus.Settings.put.X1Plus.Settings.getworks like a QML binding, and if used in a QML binding context, will dynamically retrigger the binding if the setting changes either internally tobbl_screenor externally, as part of another system user's DBus operation.Finally, we wire the lock screen's
locktypeandpasscodevariables toX1Plus.Settings, to store them in thesettings.json, and we migrate these settings on boot if they exist. To show the live QML binding behavior, we introduce ax1plus-test-settings.pythat commands the X1Plus daemon to change some settings. Test it by loading the lock screen configuration dialog, and then ssh'ing in and running something like:$ /opt/x1plus-test-settings.py passcode=1337or:
$ /opt/x1plus-test-settings.py locktype=1You should see the settings change in real time on the display.