Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent CAs from being marked as "rookie CA" #695

Closed
Xymanek opened this issue Dec 19, 2019 · 0 comments · Fixed by #938
Closed

Prevent CAs from being marked as "rookie CA" #695

Xymanek opened this issue Dec 19, 2019 · 0 comments · Fixed by #938

Comments

@Xymanek
Copy link
Member

Xymanek commented Dec 19, 2019 •
edited
Loading

The game has a concept of "rookie covert actions":

covert actions which do not have veteran soldier requirements, so can always be started

Mods can introduce CAs which do not have rank requirements, but have very specific spawn requirements, which would be ignored by current system.

I propose adding X2CovertActionTemplate::bCanNeverBeRookie to allow mods to control this behaviour (X2CovertActionTemplate is not native). The value will be checked in XComGameState_HeadquartersResistance::FindRookieCovertActions
@Xymanek Xymanek mentioned this issue Dec 19, 2019
Closed
Xymanek added a commit to WOTCStrategyOverhaul/X2WOTCCommunityHighlander that referenced this issue Dec 23, 2019
@Xymanek
Added X2CovertActionTemplate::bCanNeverBeRookie to allow mods to fo…
1bda334 
…rbid a CA from being marked as a rookie one (X2CommunityCore#695)
@Xymanek Xymanek mentioned this issue Dec 23, 2019
Merged
Musashi1584 added a commit that referenced this issue Jan 9, 2020
@Musashi1584
Merge #695 'issue-695' into beta
3b4d527
@robojumper robojumper added the needs-docs Needs documentation label Jan 18, 2020
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jan 11, 2021
Added docs for Issue X2CommunityCore#695
64abc0a
@Iridar Iridar mentioned this issue Jan 11, 2021
Merged
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jan 11, 2021
Corrected docs for Issue X2CommunityCore#695
d80a7dd
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jan 12, 2021
Added docs for Issue X2CommunityCore#475
7ac626c 
Corrected docs for Issue X2CommunityCore#695
@robojumper robojumper removed the needs-docs Needs documentation label Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add inline docs for multiple issues Iridar/X2WOTCCommunityHighlander
2 participants
@Xymanek @robojumper