Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meaningful changes to Character Generation require MCO / OPTC override #783

Closed
Iridar opened this issue Feb 23, 2020 · 1 comment · Fixed by #784
Closed

Meaningful changes to Character Generation require MCO / OPTC override #783

Iridar opened this issue Feb 23, 2020 · 1 comment · Fixed by #784

Comments

@Iridar
Copy link
Contributor

Iridar commented Feb 23, 2020

Mods like Clean Soldier Generation and Gender Bias - WOTC have to rely on a Mod Class Override in order to make changes to the appearance of generated soldiers.

I propose to add an Event to XGCharacterGenerator.uc that will trigger after the soldier appearance is generated so that mods can make arbitrary changes to it at that point.

To make this event fully functional when it comes to resistance faction soldiers will require refactoring them a bit, more details in the upcoming PR for this issue.
@Iridar
Copy link
Contributor Author

Iridar commented Feb 23, 2020 •
edited

Is 'PostUnitAppearanceGenerated' good enough name for this event?

@Iridar Iridar mentioned this issue Feb 23, 2020
Open
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Feb 23, 2020
@Iridar
Initial commit for Issue X2CommunityCore#783, event implementation.
4a27089
@Iridar Iridar mentioned this issue Feb 24, 2020
Merged
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jan 8, 2021
@Iridar
Initial commit for Issue X2CommunityCore#783, event implementation.
212b3b9
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jan 8, 2021
@Iridar
Initial commit for Issue X2CommunityCore#783, event implementation.
921d88b 
Rebase onto master.
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jan 8, 2021
@Iridar
Initial commit for Issue X2CommunityCore#783, event implementation.
02a7586
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jan 8, 2021
@Iridar
Initial commit for Issue X2CommunityCore#783, event implementation.
4d6998e 
Attempted squash.
@pledbrook pledbrook mentioned this issue Jan 9, 2021
Merged
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 28, 2021
@Iridar
Implemented Issue X2CommunityCore#783 - add DLC hook to modify genera…
d8b0784 
…ted unit appearance.
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 28, 2021
Revert "Implemented Issue X2CommunityCore#783 - add DLC hook to modif…
c82bf5e 
…y generated unit appearance."

This reverts commit d8b0784.
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 28, 2021
@Iridar
Implemented Issue X2CommunityCore#783 - add DLC hook to modify genera…
5dca8ce 
…ted unit appearance.
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 28, 2021
Revert "Implemented Issue X2CommunityCore#783 - add DLC hook to modif…
b29a11f 
…y generated unit appearance."

This reverts commit d8b0784.
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 28, 2021
Implement Issue X2CommunityCore#783 - add a DLC hook to modify genera…
c9e9c1d 
…ted unit appearance, refactored faction hero XGCharGens.
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 28, 2021
Implement Issue X2CommunityCore#783 - add a DLC hook to modify genera…
b9d2867 
…ted unit appearance, refactored faction hero XGCharGens.
@Iridar Iridar mentioned this issue Apr 3, 2022
Closed
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Apr 3, 2022
@Iridar
Issue X2CommunityCore#1140 - fix bugs introduced by Issue X2Community…
30ac9ab 
…Core#783
@Iridar Iridar mentioned this issue Apr 3, 2022
Merged
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 21, 2023
@Iridar @ps2guides
Issue X2CommunityCore#1140 - fix bugs introduced by Issue X2Community…
91a4908 
…Core#783
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 21, 2023
@ps2guides
Revert X2CommunityCore#783
0a425b8
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 21, 2023
@ps2guides
Implement Issue X2CommunityCore#1140 - fix bugs in X2CommunityCore#783
53c3e8f
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 21, 2023
@ps2guides
Implement Issue X2CommunityCore#1140 - fix bugs in X2CommunityCore#783
f09cba4
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 21, 2023
@ps2guides
Implement Issue X2CommunityCore#1140 - fix bugs in X2CommunityCore#783
08a39b7
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 21, 2023
@ps2guides
Implement Issue X2CommunityCore#1140 - fix bugs in X2CommunityCore#783 …
b132ab1 
…and update docs
@Iridar Iridar mentioned this issue May 21, 2023
Merged
Iridar pushed a commit that referenced this issue May 21, 2023
@ps2guides @Iridar
Implement Issue #1140 - fix bugs in #783 and update docs
416fdca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New DLC hook ModifyGeneratedUnitAppearance Iridar/X2WOTCCommunityHighlander
1 participant
@Iridar