Create an option to make Fatigue and Injury Times Independent

[Grobobobo]

Fixes #1148

[github-actions]

Pull request modifies event listener templates

Difference (click to expand)

diff --git a/target/CHL_Event_Compiletest.uc b/target/CHL_Event_Compiletest.uc
index c229218..ceded57 100644
--- a/target/CHL_Event_Compiletest.uc
+++ b/target/CHL_Event_Compiletest.uc
@@ -630,6 +630,24 @@ static function EventListenerReturn OnOverrideHitEffects(Object EventData, Objec
 	return ELR_NoInterrupt;
 }
 
+static function EventListenerReturn OnOverrideInjuryClearingFatigueBehavior(Object EventData, Object EventSource, XComGameState GameState, Name EventID, Object CallbackObject)
+{
+	local XComGameState_Unit UnitState;
+	local XComLWTuple Tuple;
+	local bool ShouldOverride;
+
+	UnitState = XComGameState_Unit(EventSource);
+	Tuple = XComLWTuple(EventData);
+
+	ShouldOverride = Tuple.Data[0].b;
+
+	// Your code here
+
+	Tuple.Data[0].b = ShouldOverride;
+
+	return ELR_NoInterrupt;
+}
+
 static function EventListenerReturn OnOverrideKillXp(Object EventData, Object EventSource, XComGameState GameState, Name EventID, Object CallbackObject)
 {
 	local XComGameState_Unit KilledUnit;

What? (click to expand)

The Highlander documentation tool generates event listener examples from event specifications.
This comment contains the modifications that would be made to the copy-pasteable event listeners in documentation, for PR authors and reviewers to inspect for correctness, and will automatically be kept up-to-date whenever this PR is updated.

[Iridar]

Looks good to me. Is this tested?

[Xymanek]

How does the unit status UI behave?

[Grobobobo]

I've tested it, if you just put it to false, then the unit switches to the shaken status after recovering from injury.

[Xymanek]

the unit switches to the shaken status after recovering from injury

The problem with this is that the player has no idea when the soldier will actually be available for duty

[Grobobobo]

the unit switches to the shaken status after recovering from injury

The problem with this is that the player has no idea when the soldier will actually be available for duty

I don't think it's that big of a problem, you can still clearly see the red will regardless, but even then
I imagine it'll be possible to modify the injury status message to also display shaken/tired time

[Iridar]

A systemic change like that would've been probably better implemented as a config bool, I struggle to come up with a use case where you would want different behavior for different soldiers in this regard.

The problem with this is that the player has no idea when the soldier will actually be available for duty

I agree that this is a problem as well.

However, I don't see either as grounds enough to deny this change, seeing as it preserves the vanilla behavior either way.