Fix editing covert action soldier loadouts with a controller #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for upcoming fix for editing covert action soldier loadouts with a Controller
Iridar
requested changes
May 11, 2023
Iridar
added
waiting-on-author
Full credit to this fix for kdm2k6 on issue X2CommunityCore#1035
Iridar
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using a controller, you can edit the loadout of the 1st soldier slot for any given covert action; however, you can not edit the loadout of the 2nd or 3rd.
As discovered by kdm2k6 and shared in issue #1035 this is a WOTC upstream bug, however they also discovered the solution.
Since they never submitted a pull request, I made one and tested it, but otherwise the full credit for the solution should go to them.
UICovertActions.uc file from SDK is needed to be added, and changed with the code to the working solution.
I just tested a build based on this and it works (with unmodified LWOTC).
Fixes:
#1035
long-war-2/lwotc#1378