Add MarkPlotUsed call for missions that don't use the dropship #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tedster59
changed the title
Tedster59
changed the title
Iridar
added
bug-basegame
ready-to-review
Iridar
requested changes
Jun 29, 2023
X2WOTCCommunityHighlander/Src/XComGame/Classes/X2TacticalGameRuleset.uc
Outdated
Show resolved
Hide resolved
X2WOTCCommunityHighlander/Src/XComGame/Classes/X2TacticalGameRuleset.uc
Outdated
Show resolved
Hide resolved
Iridar
added
waiting-on-author
Iridar
changed the title
BlackDog86
added
ready-to-review
Iridar
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1082
Since nothing uses Seamless traveling anymore (per a discord message from robojumper), Missions that don't involve a dropship travel animation don't mark plots as used, leading to all UFOs and Chosen Avenger Defenses for a campaign being on the same plot. This PR moves the MarkPlotsUsed code outside of the bShowDropshipInteriorWhileGeneratingMap check so that all missions have plots marked as used properly.