Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few log warnings #1226

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Fix a few log warnings #1226

merged 2 commits into from
Aug 13, 2023

Conversation

Iridar
Copy link
Contributor

@Iridar Iridar commented Jul 26, 2023

Tracking Issue #324

@Iridar Iridar added this to the 1.26.0 milestone Jul 26, 2023
@Iridar Iridar self-assigned this Jul 26, 2023
@Iridar
Copy link
Contributor Author

Iridar commented Aug 13, 2023

Note that ValidateTierXHackRewards() functions returning true even if the hack reward template is 'none' may or may not be leading to buggy behavior down the line, but fixing it is outside the scope of Issue #324. Something to keep an eye out in the future.

@Iridar Iridar force-pushed the 324-some-log-warnings branch 4 times, most recently from b1ddc9e to 99df893 Compare August 13, 2023 08:37
@Iridar Iridar merged commit 266052b into X2CommunityCore:master Aug 13, 2023
4 checks passed
@Iridar Iridar deleted the 324-some-log-warnings branch August 13, 2023 08:44
This was referenced Aug 14, 2023
Closed
Open
@remcoros remcoros mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Iridar Iridar

Labels
bug-basegame
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Iridar @ps2guides