Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dodge apply to Hit and Crit equally #1238

Merged

Conversation

Iridar
Copy link
Contributor

@Iridar Iridar commented Aug 13, 2023

Fixes #1200

An alternative fix to #1215. The original PR makes Dodge erode Hit first, and only then Crit, much like Defense does.

This PR makes Dodge apply to Hit and Crit equally, so both remain as possible outcomes as long as Dodge is <100.

@Iridar Iridar added bug-basegame ready-to-review A pull request is ready to be reviewed labels Aug 13, 2023
@Iridar Iridar added this to the 1.26.0 milestone Aug 13, 2023
@Iridar Iridar self-assigned this Aug 13, 2023
@Iridar Iridar mentioned this pull request Aug 13, 2023
@Iridar Iridar merged commit c137e4c into X2CommunityCore:master Aug 13, 2023
4 checks passed
@Iridar Iridar deleted the 1200-fix-dodge-crit-interactions branch August 13, 2023 17:39
@Iridar Iridar added ready-for-merge the pull request was reviewed and is ready to be merged. and removed ready-to-review A pull request is ready to be reviewed labels Aug 13, 2023
@Iridar
Copy link
Contributor Author

Iridar commented Aug 13, 2023

Tested and reviewed by me, Tedster and BlackDog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-basegame ready-for-merge the pull request was reviewed and is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dodge reduces Hit chance
2 participants